Commit graph

257 commits

Author SHA1 Message Date
YamaArashi
db7d941d22 constants for flag actions 2015-07-19 20:45:34 -07:00
YamaArashi
1d86932cc9 naming 2015-07-19 17:52:26 -07:00
YamaArashi
02bd91b707 jpab/jpba macros 2015-07-19 11:56:13 -07:00
dannye
64b4cf624f Merge branch 'master' of https://github.com/YamaArashi/pokered
Conflicts:
	engine/evos_moves.asm
	engine/overworld/healing_machine.asm
2015-07-19 03:52:20 -05:00
dannye
ea9cc86949 Name sound effects 2015-07-19 03:46:12 -05:00
YamaArashi
c169073eed misc 2015-07-18 21:58:55 -07:00
dannye
148d3f3cf2 Consolidate coord macros 2015-07-18 15:52:03 -05:00
YamaArashi
fc9af362ae fix variable naming 2015-07-18 08:17:46 -07:00
YamaArashi
bd7d981593 menu stuff 2015-07-15 20:04:58 -07:00
YamaArashi
994c2cbf28 named wram variables 2015-07-14 23:16:06 -07:00
YamaArashi
07dd705637 hall of fame / credits 2015-07-14 19:46:52 -07:00
YamaArashi
01631a2e59 player animations, emotion bubbles, etc. 2015-07-14 14:32:49 -07:00
dannye
b1cb378893 Comment naming screen
also use more joypad constants
2015-07-14 03:49:49 -05:00
dannye
ef9e59101e Use more screen dimension constants 2015-07-14 02:16:19 -05:00
dannye
e25a7148d0 Merge branch 'master' of https://github.com/YamaArashi/pokered
Conflicts:
	engine/town_map.asm
2015-07-14 00:58:09 -05:00
dannye
b509b48a7f Use more *Coord
also town map code relabelling
YamaArashi just did town map relabelling but oh well
I aleady made the changes and don't feel like redoing it
2015-07-14 00:21:03 -05:00
YamaArashi
0066e09828 named party menu/naming screen wram variables 2015-07-13 15:40:33 -07:00
YamaArashi
f66a74b9fc comment slot machine 2015-07-13 13:35:35 -07:00
YamaArashi
95b1660e59 menu wram variable names 2015-07-13 00:32:03 -07:00
YamaArashi
4a8c9993ad named wram variables 2015-07-12 23:00:48 -07:00
YamaArashi
99df5f0fd7 use constant for bg transfer dest hram var 2015-07-12 16:37:06 -07:00
YamaArashi
849b53623b shake screen functions 2015-07-12 16:24:03 -07:00
YamaArashi
a957bb1540 some battle animation stuff 2015-07-12 15:51:04 -07:00
U-Daniel-PC\Daniel
8431fa7756 TX_ASM 2015-07-03 14:58:50 -05:00
U-Daniel-PC\Daniel
cd649184f5 Rename/organize part 1 of 4
rename functions, clean up address/wram comments, other misc
only broken up so that all changes are viewable on github
2015-07-03 14:37:53 -05:00
U-Daniel-PC\Daniel
ae420a4d8f Mention Jap grammar 2015-06-12 13:45:52 -05:00
U-Daniel-PC\Daniel
4e3cd633f0 Document code related to MonName1Text 2015-06-12 13:40:51 -05:00
U-Daniel-PC\Daniel
39abace569 Clean up white space 2015-06-11 17:41:33 -05:00
Daniel Harding
c43c338a5f Merge pull request #96 from dannye/master
wram comments, EOLs, EOFs, and UTF-8
2015-06-04 23:02:28 -05:00
U-Daniel-PC\Daniel
bdfd6ac09b ANSI->UTF-8 2015-06-04 23:01:40 -05:00
U-Daniel-PC\Daniel
10fd288ab4 Add newlines to EOFs 2015-06-01 22:15:02 -05:00
IIMarckus
26d279b551 Fix a hardcoded value by replacing it with a variable. 2015-05-31 09:15:52 -06:00
xCrystal
9739c26ed7 money won and trainer pic constants 2015-04-09 13:05:57 +02:00
xCrystal
9c93ef3bff user xor operator for clearing status flags
use xor operator for clearing status flags
2015-04-09 11:35:37 +02:00
xCrystal
61edd43974 Document DisableEffect and CheckEnemyStatusConditions
basically copy/paste comments and labels from
CheckPlayerStatusConditions
2015-04-09 01:17:56 +02:00
xCrystal
b2dc57576d Document move effects
Document mist effect

Document recoil effect

Document heal effect

Update conversion_effect.asm

Update haze_effect.asm

Update leech_seed_effect.asm

Update pay_day_effect.asm

Update reflect_light_screen_effect.asm

Update substitute_effect.asm

Update transform_effect.asm
2015-04-08 23:54:29 +02:00
xCrystal
ce9940a2eb Further split bank e stuff 2015-04-01 17:27:51 +02:00
xCrystal
10211cc461 Rename battle files and split move effects Part 5
15.asm, 16.asm, 1a.asm, 1c.asm
2015-04-01 17:05:51 +02:00
xCrystal
2fe782b11a Rename battle files and split move effects Part 4
e.asm, e_2. asm, and 14.asm
2015-04-01 17:05:50 +02:00
xCrystal
77d0e5ff84 Rename battle files and split move effects Part 3
b.asm, b_2.asm, c.asm, and d.asm
2015-04-01 17:05:49 +02:00
xCrystal
46c2a38c7c Rename battle files and split move effects Part 2
5.asm, 9.asm, and a.asm
2015-04-01 17:05:43 +02:00
xCrystal
e74dce24b4 Rename battle files and split move effects Part 1
1.asm, 4.asm, and 4_2.asm
2015-04-01 17:05:10 +02:00
xCrystal
9d93b5b630 Document animation types (shake screen/blink pic) 2015-03-31 23:45:57 +02:00
xCrystal
4e2084b0f1 Name more in-battle functions and labels
and better document some animation related functions
2015-03-31 22:22:12 +02:00
xCrystal
e6185ac358 Label some attack animation functions 2015-03-31 21:09:43 +02:00
xCrystal
c73b5d73f4 Label some battle related functions 2015-03-31 20:50:49 +02:00
xCrystal
4ba8dd6090 Further document AI stuff 2015-03-31 20:40:22 +02:00
xCrystal
247b619e9a Some wram constants 2015-03-31 20:28:42 +02:00
xCrystal
a8375aaee7 Split commentary lines that are too long 2015-03-31 20:16:31 +02:00
U-Daniel-PC\Daniel
1c2a1076cb Low health alarm documentation
RenaKunisaki
2015-03-12 10:49:35 -04:00
U-Daniel-PC\Daniel
6cb51a1c4e Label typo
closes https://github.com/iimarckus/pokered/issues/81
2015-02-26 23:27:51 -05:00
YamaArashi
7b7c563c93 Rename some labels 2015-02-08 18:40:08 -08:00
YamaArashi
3870f5e10a named misc functions 2015-02-08 01:44:41 -08:00
YamaArashi
1347023128 move-related things 2015-02-08 00:17:03 -08:00
YamaArashi
72bbaed99f fixed hp bar wram label and misc 2015-02-07 22:18:42 -08:00
YamaArashi
32f7cf12de Named wram symbols 2015-02-07 18:37:40 -08:00
YamaArashi
4fd7a42b23 commented battle stuff 2015-02-07 16:24:16 -08:00
YamaArashi
72265ab92a comment drain HP effect 2015-02-07 13:40:14 -08:00
YamaArashi
83023cda19 commented menu stuff 2015-02-07 12:27:36 -08:00
YamaArashi
c9b778fb00 documented bide bug 2015-02-07 04:23:34 -08:00
YamaArashi
3fdb8a0d89 serial/trade/misc 2015-02-07 02:43:08 -08:00
xCrystal
9de54645c8 add constants for volatile statuses and more battle labels/commentary/constants 2015-02-04 23:22:46 -08:00
xCrystal
97637e7ce7 More battle commentary/labels/constans and fix some spacing issues
Conflicts:
	engine/battle/core.asm
2015-02-04 23:22:25 -08:00
IIMarckus
01e314f4f5 Merge branch 'master' of /tmp/a/pokered 2015-02-04 00:51:25 -07:00
Marcus Huderle
c3a5bb70d2 Use money macro for TrainerPicAndMoneyPointers. 2015-02-04 00:51:12 -07:00
U-Daniel-PC\Daniel
a53b3ca561 More battle sfx ids 2015-01-27 03:27:34 -05:00
U-Daniel-PC\Daniel
49a25618ea Clean up white space, fix label typo 2015-01-22 22:13:21 -05:00
xCrystal
d3bf8bca5e fix duplicate labels 2015-01-21 11:24:55 +01:00
xCrystal
e6499cd505 some constants in stat up/down effects 2015-01-20 20:34:56 +01:00
xCrystal
61aaa15205 rename some labels 2015-01-20 20:21:16 +01:00
xCrystal
1b62ca0555 add commentary to move effects 2015-01-20 12:12:30 +01:00
xCrystal
ca6b4348c2 add commentary 2015-01-04 17:47:21 +01:00
yenatch
26227cc45f Clean up type names. 2014-12-10 20:07:01 -08:00
IIMarckus
ba1a56d05c Fix typo introduced in last commit. 2014-10-22 23:30:09 -06:00
IIMarckus
d0bb99ec89 Add Yellow’s slot machine graphics. 2014-10-21 01:31:34 -06:00
IIMarckus
a3d3f8324a Kill version.asm. 2014-10-17 02:42:32 -06:00
IIMarckus
bf6a1bab61 Better document the “can encounter Pokémon outside grass” code.
Pointed out by Lin.
2014-10-10 03:44:52 -06:00
IIMarckus
6e14461fa6 Add a lot of Yellow text changes. 2014-10-10 01:46:06 -06:00
yenatch
070c964964 Accidentally committed .orig files from merge dff0cdeb. 2014-09-23 15:08:12 -07:00
yenatch
a81487e9c6 Rename hVBlank* constants to h*. 2014-09-23 15:02:03 -07:00
yenatch
dff0cdeb5a Merge remote-tracking branch 'YamaArashi/master'
Conflicts:
	constants/misc_constants.asm
	engine/battle/core.asm
	engine/menu/pokedex.asm
	engine/town_map.asm
	home.asm
	hram.asm
2014-09-20 00:57:27 -04:00
yenatch
aa361c3bf7 Use move animation constants instead of static values.
This allows new moves and animations to be added without overlap.
2014-09-17 12:37:47 -07:00
YamaArashi
2ed65d9c3e Commented/labelled misc functions 2014-09-14 11:29:18 -07:00
YamaArashi
0c916aea33 Commented more sprite and map code 2014-09-13 00:50:56 -07:00
YamaArashi
91793015e5 Labelled and commented mostly sprite-related things 2014-09-09 20:55:19 -07:00
yenatch
365ae68d80 Use PARTY_LENGTH and related constants in menu and hud code.
This should allow reducing PARTY_LENGTH to work as intended.
Increasing it also works provided space is provided in wram, but breaks pc/saving.
2014-08-22 23:17:47 -07:00
YamaArashi
59f0507e4c Labelled many functions/variables 2014-08-08 22:39:13 -07:00
yenatch
1cf79b6f15 Fix static banks passed into GetName.
This appears to be the only other use of wPredefBank.

Chances are there are more uncaught banks. Known cases are marked as "hardcoded" or similar.
2014-08-07 21:17:44 -07:00
U-Fish-PC\Daniel
bd533aa79b Use *Coord instead of FuncCoord
Using 'Coord =' doesn't like using wTileMap
So use hlCoord, deCoord, bcCoord, aCoord, Coorda, or dwCoord
to avoid static addresses
2014-06-25 16:58:27 -04:00
yenatch
b36f793667 Use macros for predef calls/jumps instead of static ids. 2014-06-16 13:57:26 -07:00
yenatch
d10108a066 Use macros to define predefs. 2014-06-16 13:25:46 -07:00
yenatch
35f2bb90d4 Rename predef functions so they aren't excessive in length.
This is mostly because of an rgbasm bug that prevents macro arguments
from exceeding 16 characters, but the names were bad anyway.
2014-06-16 13:03:05 -07:00
yenatch
38ac74f222 Remove generated "indirect jump" comments.
The destination is obvious when using the predef macro.
2014-06-16 11:37:36 -07:00
yenatch
53ae0e93fa Use monster struct macros in wram. Rename related labels for consistency. 2014-06-14 04:12:40 -07:00
U-Fish-PC\Daniel
9eefed45f7 Use MAX_LEVEL instead of 100/$64 2014-06-10 17:06:30 -04:00
U-Fish-PC\Daniel
286c160c27 Merge branch 'master' of https://github.com/yenatch/pokered
Conflicts:
	engine/battle/1c.asm
2014-05-30 13:17:47 -04:00
U-Fish-PC\Daniel
c8a5720cca Fix IsDungeonMap comments 2014-05-30 06:11:18 -04:00
U-Fish-PC\Daniel
0221c1831e Label and comment BattleTransition 2014-05-29 14:21:41 -04:00
yenatch
da0a72cdbf Use VRAM constants where applicable. 2014-05-29 01:31:46 -07:00
yenatch
40c17c906b Remove most static wram addresses. Use labels instead.
For unknown addresses, use "w<address>".

Label overleads are still an issue.
2014-05-26 22:04:39 -07:00
yenatch
4be11293e5 Label BCD math predefs. 2014-05-25 17:27:02 -07:00
yenatch
031e33957d Rename joypad registers. 2014-05-25 10:53:09 -07:00
yenatch
d307c85499 Clean up some bank 3 functions and rename flag action functions. 2014-05-25 10:09:39 -07:00
yenatch
64479cd642 Rename random number function and hram labels.
GenRandom -> Random
GenRandomInBattle -> BattleRandom
H_RAND1 -> hRandomAdd
H_RAND2 -> hRandomSub
2014-05-24 11:40:38 -07:00
yenatch
8f8281fe6e Comment some more bank 0 functions. 2014-05-23 15:34:35 -07:00
yenatch
0dea0cc3fb Comment some bank 0 functions, and add wram labels for Predef. 2014-05-23 15:11:09 -07:00
U-Fish-PC\Daniel
15427f5320 Pull a lot of engine out of main.asm 2014-05-22 18:13:20 -04:00