Commit graph

257 commits

Author SHA1 Message Date
Vortyne
c3f297e98b
Fix comment: Road -> Roar (#466) 2024-09-24 07:32:47 -05:00
Sylvie
8f1dcf07e5
Identify more flag bits (#464) 2024-09-23 23:51:44 -04:00
Sylvie
5a622f628d
Identify remaining uses of wd0b5 and wd11e (#463) 2024-09-18 21:41:58 -04:00
Sylvie
613d34678b
Split hSpriteIndexOrTextID into hSpriteIndex and hTextID (#462)
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
Vortyne
1f6e2bf999
Use correct label in get_trainer_name.asm (#461) 2024-09-09 20:22:58 -04:00
Sylvie
77d051479b
Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) 2024-08-04 10:05:33 -04:00
Sylvie
6e3ab0a9e9
Identify wcd6d as wNameBuffer and others (#455) 2024-07-24 12:21:59 -04:00
Sylvie
8fafca714c
Identify various flag labels and bit constants (#454) 2024-07-16 13:02:54 -04:00
Sylvie
fc23e72a39
Identify some unused WRAM variables (#453) 2024-06-15 12:18:00 -04:00
dannye
a247120ac1 Fix a few usages of EFFECTIVE 2023-11-21 20:18:04 -06:00
Rangi42
d4e7a39dd8 Use some more constants in place of raw numbers 2023-11-21 20:15:30 -05:00
RainbowMetalPigeon
465b859c4c
Replace some $a with EFFECTIVE (#399) 2023-11-21 20:01:20 -05:00
BlueZangoose
9827190aea
Use MEGA_PUNCH constant in explosion animation routine (#434)
* Use MEGA_PUNCH constant in explosion animation routine

* Add AnimationType constants and assert

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-21 19:52:53 -05:00
Rangi42
b066d3c9bc Add bigdw and dc data macros 2023-11-20 17:53:19 -05:00
strager
30c244ae4f
Use PSN constant in PoisonEffect routine (#426) 2023-09-20 15:43:27 -04:00
Linus Unnebäck
c42b7167ce
Use charmap in link_battle_versus_text (#415) 2023-07-16 16:21:20 -05:00
SatoMew
f46db37d50
Thoroughly document debug code (#410) 2023-07-15 18:36:59 -04:00
Vortyne
17eaf761e3
Name some unnamed animation constants (#396) 2023-03-25 23:31:59 -04:00
BlueZangoose
0f5a9eb146
Change names of move subanimations to be meaningful (#389)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-09-25 14:17:39 -04:00
Rangi
bbb0e7e82d
Use the same music headers as pokecrystal (#382) 2022-08-11 21:23:08 -04:00
SatoMew
ac7263b1ad
Update comments related to Swift and Substitute checks (#380)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-11 21:22:57 -04:00
Rangi
498da6ab09 Clarify how Metronome picks a move 2022-07-26 00:01:21 -04:00
Rangi
8f81e71f19 Identify some .asm_* labels 2022-07-10 21:11:03 -04:00
Colton G. Rushton
cc46b0e510
wOAMBuffer -> wShadowOAM (#370) 2022-07-09 17:18:18 -04:00
vulcandth
fcd6e5a1b2
Stop_reducing_move_anim_flashing_Dream_Eater -> Stop_reducing_move_anim_flashing_Blizzard (#369) 2022-06-30 21:24:33 -04:00
Rangi
4e96f9d232 cp MR_FUJIS_HOUSE -> cp POKEMON_TOWER_7F + 1
Fixes #362
2022-06-17 22:58:46 -04:00
vulcandth
edb55e00f8
Rename SLP to SLP_MASK (#361)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-06-17 22:25:52 -04:00
vulcandth
6b5be9129c
RGBDS syntax updates (#358)
New MACRO and DEF syntax
2022-06-06 17:25:31 -04:00
vulcandth
d7808d110f
Improved Virtual Console patch identifiers (#357) 2022-06-06 17:22:34 -04:00
vulcandth
fe8d3c51a4
Build the Virtual Console patches with make red_vc and make blue_vc (#351) 2022-03-26 16:59:36 -04:00
Rangi
7e78c1171d Gen 1's Minimize graphic was not a complete 8x8 tile 2022-03-04 18:21:12 -05:00
Rangi
09e92c554c Use ~X instead of $ff ^ X 2021-11-23 21:00:07 -05:00
Yoann Fievez
f68af5c6e9
Add some constants for options (#344)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2021-11-05 19:45:09 -04:00
Yoann Fievez
8349bfd8e6
Refactorize check button pressed (#340) 2021-11-05 15:40:15 -04:00
Rangi
2ee8ce26da Comment on the CooltrainerFAI bug
Fixes #308
2021-11-03 17:07:08 -04:00
Rangi
58d08bff43 Identify some percentage constant values 2021-11-02 19:57:08 -04:00
Amber Brault
30acb46b98
Fix typos (#334) 2021-09-26 21:57:55 -05:00
Rangi
7ee8a6509e wcf4b -> wStringBuffer 2021-08-28 17:02:20 -04:00
SnorlaxMonster
319c29c751 Correct comments on SwitchAndTeleportEffect
The comments in the SwitchAndTeleportEffect section incorrectly stated
that the random number was generated in the
half-open interval [0, playerLevel + enemyLevel),
instead of the closed interval [0, playerLevel + enemyLevel].
2021-06-14 21:47:19 +10:00
Rangi
f9ae7b1240 More WRAM label cleanup (still needs UNIONs and renaming) 2021-05-31 16:25:16 -04:00
Rangi
8701ef4d61 Improve some RAM formatting 2021-05-31 11:46:10 -04:00
Rangi
c8626595b4 Use BANK("Pics #") for Pokémon and trainer pics 2021-05-06 23:04:00 -04:00
Rangi
6a31663c96 Use {interpolation} to generate sequences of RAM labels
Fixes #319
2021-04-27 15:49:59 -04:00
dannye
fa206ce835 Fix incorrect sfx id
AUDIO_1 is loaded during trade animations, not AUDIO_2
2021-03-30 01:03:30 -05:00
Rangi
95ec2cf039 Verify data table and name list sizes with assertion macros
Fixes #312
2021-03-25 16:44:41 -04:00
dannye
5c9c7bf362 Clean up handling of extra effective status effects 2021-02-21 11:43:38 -06:00
Rangi
95353fdefa Identify hUILayoutFlags 2021-02-13 19:48:34 -05:00
SatoMew
083cb38e33 Update related tile animation constants 2020-11-29 21:28:38 +00:00
SatoMew
242b2e05cf Label and document hFFD7 more accurately 2020-11-29 20:17:29 +00:00
Rangi
6adbaefde1 Keep wGrassMons and wWaterMons together with a UNION 2020-11-28 17:11:12 -05:00