Changing the following macro names:
unknownsfx0x20 to SquareSound - This command, when used in an .asm file that defines an audio piece, generates a square tone modulated by 4 values.
unknownnoise0x20 to NoiseSound - This command is similar to SquareSound, but it uses 3 values instead of 4 and generates noise instead of a square tone.
unknownsfx0x10 to eSquarePitchEnvelope - This command is not an unknown sound effect, but a modifier for the above two commands which it precedes; it takes one decimal value which is translated into a hexadecimal value when used by the system, and depending on the second digit of this hex value the sounds generated by SquareSound and NoiseSound will have their frequency slide either up (1-7) or down (9-F) or not at all (0,8). E.g. typing 23 will have the system read $17, which will modulate the frequency to slide up because the second digit is 7.
The old mnemonics generate warnings with new versions of rgbds. This
patch replaces them by the correct ones.
Signed-off-by: Antonio Niño Díaz <antonio_nd@outlook.com>
For unknown reasons, the text pointer list for Oak's Lab is
duplicated. This is currently implemented by treating the
two text pointer lists as one large list. This leads to
duplicate labels and some confusing logic.
Refactor the code to treat the two text pointer lists
separately. This lets us remove several labels. It also
makes the code which sets the text pointer list
self-documenting.
EngageMapTrainer should write to wEngagedTrainerClass and
wEngagedTrainerSet, not wEngagedTrainerClass and
wEnemyMonAttackMod. wEnemyMonAttackMod doesn't make any
sense in this context. Use the correct variable.
These two variables happen to have the same address, so
there is no functional difference between using
wEnemyMonAttackMod versus using wEngagedTrainerSet.
