Commit graph

451 commits

Author SHA1 Message Date
Vortyne
678d014aef
FreezeEnemyTrainerSprite -> SetEnemyTrainerToStayAndFaceAnyDirection 2024-10-07 12:03:26 -04:00
Vortyne
1aa3fb24ec
dbsprite is the wrong macro for WriteOAMBlock data (#472) 2024-09-29 18:54:41 -04:00
Vortyne
af36156a5b
This byte is written to, but not used (#471)
it's written to in init_player_data.asm

```
	ld hl, wObtainedBadges
	ld [hli], a
	ld [hl], a
```
2024-09-25 22:02:15 -05:00
Sylvie
635b9c4cab
Identify wCurrentMapScriptFlags bits (#467) 2024-09-24 11:39:44 -04:00
Sylvie
6ae63a8cea
Identify hardware register bits (#469) 2024-09-24 10:48:10 -04:00
Sylvie
b5d2540e7c
Identify more bit flags (#465)
* Identify more bit flags

* Space
2024-09-24 09:33:33 -04:00
Vortyne
c3f297e98b
Fix comment: Road -> Roar (#466) 2024-09-24 07:32:47 -05:00
Sylvie
8f1dcf07e5
Identify more flag bits (#464) 2024-09-23 23:51:44 -04:00
Sylvie
5a622f628d
Identify remaining uses of wd0b5 and wd11e (#463) 2024-09-18 21:41:58 -04:00
Sylvie
613d34678b
Split hSpriteIndexOrTextID into hSpriteIndex and hTextID (#462)
Also identify `wPPUpCountAndMaxPP`
2024-09-18 21:01:18 -04:00
Vortyne
1f6e2bf999
Use correct label in get_trainer_name.asm (#461) 2024-09-09 20:22:58 -04:00
Sylvie
77d051479b
Identify wcf91 as wCurPartySpecies, wCurItem, and wCurListMenuItem (#457) 2024-08-04 10:05:33 -04:00
Sylvie
6e3ab0a9e9
Identify wcd6d as wNameBuffer and others (#455) 2024-07-24 12:21:59 -04:00
Sylvie
8fafca714c
Identify various flag labels and bit constants (#454) 2024-07-16 13:02:54 -04:00
Sylvie
fc23e72a39
Identify some unused WRAM variables (#453) 2024-06-15 12:18:00 -04:00
dannye
d870ad6ea8 Fix hard-coded bank 2024-05-05 09:41:56 -05:00
Rangi
fabe2b3fb3
Update to RGBDS 0.7.0 (#447) 2024-01-03 10:59:04 -05:00
SatoMew
07cefd462f
Clean up item comments (#443) 2023-12-18 18:30:37 -06:00
colawsol
f6017ddbfd
Correct StarterDex function comment (#440) 2023-12-06 19:34:37 -06:00
vulcandth
1dcc16b347 Delete a couple EOL whitespace. 2023-11-22 15:09:21 +00:00
dannye
a247120ac1 Fix a few usages of EFFECTIVE 2023-11-21 20:18:04 -06:00
Rangi42
41ec74e1f0 Fix inaccurate comment in UpdateNPCSprite
Fixes #404
2023-11-21 20:36:00 -05:00
Rangi42
0a616ae560 Get rid of wEvosMoves, MAX_EVOLUTIONS, and EVOLUTION_SIZE
Fixes #430
2023-11-21 20:33:03 -05:00
Rangi42
d4e7a39dd8 Use some more constants in place of raw numbers 2023-11-21 20:15:30 -05:00
RainbowMetalPigeon
465b859c4c
Replace some $a with EFFECTIVE (#399) 2023-11-21 20:01:20 -05:00
SatoMew
a681f718ac
Rename EV_* constants to EVOLVE_* like pokecrystal (#407) 2023-11-21 19:54:39 -05:00
BlueZangoose
9827190aea
Use MEGA_PUNCH constant in explosion animation routine (#434)
* Use MEGA_PUNCH constant in explosion animation routine

* Add AnimationType constants and assert

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-21 19:52:53 -05:00
Rangi42
77887be251 Identify wSavedCoordIndex and its other usages 2023-11-20 18:53:23 -05:00
Rangi42
b066d3c9bc Add bigdw and dc data macros 2023-11-20 17:53:19 -05:00
Vortyne
7a7a6d689c
Identify the unnamed HRAM variables and one WRAM label (#438) 2023-11-20 17:23:22 -05:00
Vortyne
5739aea990
Name unnamed labels in seafoam islands and pokemon mansion script files (#435)
* Update PokemonMansion1F.asm

* Name unnamed seafoam/mansion labels
2023-11-19 15:09:33 -06:00
Rangi42
26a342b104 Identify more map script labels 2023-11-18 19:44:03 -05:00
vulcandth
64061e2092 .calculateHPBarCoords incorrectly referenced OAM
Resolves #411

Co-Authored-By: SnDream <12762219+sndream@users.noreply.github.com>
2023-11-17 22:36:21 -06:00
Linus Unnebäck
83b373ad73
Add constants for wMapConnections bits and group map header wram labels
* Add constants for wMapConnections bits

* Apply Vulcandth and Rangi42 feedback

---------

Co-authored-by: vulcandth <vulcandth@gmail.com>
2023-11-17 12:50:27 -06:00
strager
30c244ae4f
Use PSN constant in PoisonEffect routine (#426) 2023-09-20 15:43:27 -04:00
SatoMew
a38c7922dd
Improve comment about the "ED" tile bug (#421) 2023-07-16 20:22:06 -05:00
Linus Unnebäck
c42b7167ce
Use charmap in link_battle_versus_text (#415) 2023-07-16 16:21:20 -05:00
SatoMew
f46db37d50
Thoroughly document debug code (#410) 2023-07-15 18:36:59 -04:00
vulcandth
d001ced41b
Add macros, constants, and labels for map scripts and text (#367)
This introduces `def_script_pointers`, `def_text_pointers`, and `object_const_def` macros, and applies them to all maps. Most other map labels have also been identified.
2023-07-13 21:27:56 -04:00
Vortyne
17eaf761e3
Name some unnamed animation constants (#396) 2023-03-25 23:31:59 -04:00
SatoMew
5c4795d5bc
Complete and improve debug name labels (#408) 2023-02-26 11:14:21 -05:00
Rangi
22859c4bb7
Revert PR #395 2022-09-26 15:17:26 -04:00
Vortyne
742dd00eb7
Bug: Sprites can receive the wrong movement byte (#395)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-09-26 14:53:16 -04:00
BlueZangoose
0f5a9eb146
Change names of move subanimations to be meaningful (#389)
Co-authored-by: Rangi <remy.oukaour+rangi42@gmail.com>
2022-09-25 14:17:39 -04:00
Rangi
c299cf1067 Use a SPRITE_SET_LENGTH constant 2022-09-24 11:39:39 -04:00
Rangi
d2be79adf1
Add constants and table macros for the map sprite sets (#392)
Fixes #391
2022-09-24 11:30:29 -04:00
Rangi
bbb0e7e82d
Use the same music headers as pokecrystal (#382) 2022-08-11 21:23:08 -04:00
SatoMew
ac7263b1ad
Update comments related to Swift and Substitute checks (#380)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
2022-08-11 21:22:57 -04:00
Chatot4444
8b19405590
Replace Hard-Coded Number With Constant (#381)
Replace a hard coded $a in CheckMapForMon with NUM_WILDMONS
2022-08-11 07:51:18 -05:00
Rangi
498da6ab09 Clarify how Metronome picks a move 2022-07-26 00:01:21 -04:00