mirror of
https://github.com/pret/pokered.git
synced 2024-10-22 22:55:31 +00:00
Add comment about audio engine perfect pitch bug (#451)
Co-authored-by: preeyan <preeyan>
This commit is contained in:
parent
5f7b444ae8
commit
d38cf5281a
3 changed files with 6 additions and 3 deletions
|
@ -831,7 +831,8 @@ Audio1_note_pitch:
|
|||
bit BIT_PERFECT_PITCH, [hl] ; has toggle_perfect_pitch been used?
|
||||
jr z, .skipFrequencyInc
|
||||
inc e ; if yes, increment the frequency by 1
|
||||
jr nc, .skipFrequencyInc
|
||||
jr nc, .skipFrequencyInc ; Likely a mistake, because `inc` does not set flag C.
|
||||
; Fortunately this does not seem to affect any notes that actually occur.
|
||||
inc d
|
||||
.skipFrequencyInc
|
||||
ld hl, wChannelFrequencyLowBytes
|
||||
|
|
|
@ -842,7 +842,8 @@ Audio2_note_pitch:
|
|||
bit BIT_PERFECT_PITCH, [hl] ; has toggle_perfect_pitch been used?
|
||||
jr z, .skipFrequencyInc
|
||||
inc e ; if yes, increment the frequency by 1
|
||||
jr nc, .skipFrequencyInc
|
||||
jr nc, .skipFrequencyInc ; Likely a mistake, because `inc` does not set flag C.
|
||||
; Fortunately this does not seem to affect any notes that actually occur.
|
||||
inc d
|
||||
.skipFrequencyInc
|
||||
ld hl, wChannelFrequencyLowBytes
|
||||
|
|
|
@ -831,7 +831,8 @@ Audio3_note_pitch:
|
|||
bit BIT_PERFECT_PITCH, [hl] ; has toggle_perfect_pitch been used?
|
||||
jr z, .skipFrequencyInc
|
||||
inc e ; if yes, increment the frequency by 1
|
||||
jr nc, .skipFrequencyInc
|
||||
jr nc, .skipFrequencyInc ; Likely a mistake, because `inc` does not set flag C.
|
||||
; Fortunately this does not seem to affect any notes that actually occur.
|
||||
inc d
|
||||
.skipFrequencyInc
|
||||
ld hl, wChannelFrequencyLowBytes
|
||||
|
|
Loading…
Reference in a new issue